From 4b16828cda7b195d32722f0adf4a78816a5c159a Mon Sep 17 00:00:00 2001 From: haya14busa Date: Sun, 19 Jan 2020 06:10:10 +0000 Subject: [PATCH] fix https://github.com/koalaman/shellcheck/wiki/SC2039 --- entrypoint.sh | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/entrypoint.sh b/entrypoint.sh index 0b1e874..b0b8295 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -18,16 +18,17 @@ fi echo "Current ${VERSION_NAME}=${CURRENT_VERSION}" # Get latest semantic version release tag name from GitHub Release API. -GITHUB_AUTH_HEADER=() -if [ -n "${INPUT_GITHUB_TOKEN}" ]; then - GITHUB_AUTH_HEADER=(-H "Authorization: token ${INPUT_GITHUB_TOKEN}") - echo "Use INPUT_GITHUB_TOKEN to get release data." -else - echo "INPUT_GITHUB_TOKEN is not available. Subscequent GitHub API call can fail due to API limit." -fi - +list_releases() { + if [ -n "${INPUT_GITHUB_TOKEN}" ]; then + echo "Use INPUT_GITHUB_TOKEN to get release data." >&2 + curl -s -H "Authorization: token ${INPUT_GITHUB_TOKEN}" "https://api.github.com/repos/${REPO}/releases" + else + echo "INPUT_GITHUB_TOKEN is not available. Subscequent GitHub API call can fail due to API limit." >&2 + curl -s "https://api.github.com/repos/${REPO}/releases" + fi +} LATEST_VERSION=$(\ - curl -s ${GITHUB_AUTH_HEADER[@]} "https://api.github.com/repos/${REPO}/releases" | \ + list_releases | \ jq -r '.[] | .tag_name' | \ sed 's/^v//' | \ grep -P '\d+\.\d+\.\d+' | \